[MINSTALL-197] Update to parent 41, cleanup #61
Conversation
In general perform a cleanup of plugin, apply updates where needed. The plugin now builds against 3.9.x latest, and minimum is lifted to 3.6.3. --- https://issues.apache.org/jira/browse/MINSTALL-197
| @@ -72,21 +72,21 @@ | |||
|
|
|||
| <properties> | |||
| <javaVersion>8</javaVersion> | |||
| <mavenVersion>3.2.5</mavenVersion> | |||
| <mavenVersion>3.9.6</mavenVersion> | |||
There was a problem hiding this comment.
This lifts API to 3.9.6, isn't that a contradiction?
There was a problem hiding this comment.
Contradiction to what? The CI is updated by Slawek, so is build using 3.6.3/3.9.3 (see matrix), so min/max Maven is used, and deprecations immediately popped out (and were fixed as well).
There was a problem hiding this comment.
One is build, one API, no? Thought we raise at least build requirement to 3.6.3...
There was a problem hiding this comment.
If we'd raise (well, lower, as this PR raises to 3.9.6) build to 3.6.3 we'd see deprecations from 2019, those from 5 years ago, no? We should build against latest, to see all current deprecations, and backward compat allows us to state (and test it) even with older maven versions, like CI shows (3.6.3 used as well). Unsure what is the question actually...
There was a problem hiding this comment.
Let me think about that tomorrow or so...
src/test/java/org/apache/maven/plugins/install/stubs/InstallArtifactStub.java
Show resolved
Hide resolved
In general perform a cleanup of plugin, apply updates where needed. The plugin now builds against 3.9.x latest, and minimum is left as is (3.2.5).
A notable change along that above is removal of "baked in" packaging, now plugin relies completely and only on what project and artifact tells, there is no "if this is POM" check anymore. The new "BOM UT" shows this in action. Has to be noted though, that the UT tests ONLY the plugin, to use BOM packaging you need Maven that knows what it is (Maven 3 w/ extension or Maven 4 that has it OOTB).
https://issues.apache.org/jira/browse/MINSTALL-197