[MNG-7667] Fix DownloadMojo to properly resolve #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The m-p-p depends on m-p-tools-and and m-p-tools-beanshell as runtime/optional, and the way DownloadMojo resolves every artifacy causes that OptionalDependencySelector filter these out even at "collection" stage (as depth >= 2). This is NOT happening while m-p-p resolved as plugin, as there m-p-p artifact POM is built and each dependency is being resolved (hence all the "depth levels" are shifted for -1). Doing this in DownloadMojo would tremendously slow down the process, so adding a hack instead: when m-p-p is being resolved, we use "hack" session that omits OptionalDependencySelector. --- https://issues.apache.org/jira/browse/MNG-7667
|
Am redoing this, instead of hack make it proper, turns out reading POM is not such a big overhead (and is anyway done already as part of collection). |
cstamas
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The m-p-p depends on m-p-tools-ant and m-p-tools-beanshell as runtime/optional, and the way DownloadMojo resolves every artifact causes that OptionalDependencySelector filter these out even at "collection" stage (as depth >= 2).
Hence, fix DownloadMojo to resolve properly, that actually shifts all the tree "one level up", and hence result is same as in Maven, as the optional dependencies become "first level sibling".
https://issues.apache.org/jira/browse/MNG-7667