Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7667] Fix DownloadMojo to properly resolve #236

Merged
merged 4 commits into from
Jan 16, 2023
Merged

[MNG-7667] Fix DownloadMojo to properly resolve #236

merged 4 commits into from
Jan 16, 2023

Commits on Jan 16, 2023

  1. [MNG-7667] Improve fix that cover m-p-p peculiarity 

    The m-p-p depends on m-p-tools-and and m-p-tools-beanshell as
runtime/optional, and the way DownloadMojo resolves every
artifacy causes that OptionalDependencySelector filter these
out even at "collection" stage (as depth >= 2).

This is NOT happening while m-p-p resolved as plugin, as there
m-p-p artifact POM is built and each dependency is being resolved
(hence all the "depth levels" are shifted for -1).

Doing this in DownloadMojo would tremendously slow down the process,
so adding a hack instead: when m-p-p is being resolved, we use
"hack" session that omits OptionalDependencySelector.

---

https://issues.apache.org/jira/browse/MNG-7667
    @cstamas
    cstamas committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    4593c4e View commit details
    Browse the repository at this point in the history

  2. Fix and make bootstrap resolve proper

    @cstamas
    cstamas committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    ebd2e38 View commit details
    Browse the repository at this point in the history

  3. Simplify, collect does same (and merges) for us

    @cstamas
    cstamas committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    b880b74 View commit details
    Browse the repository at this point in the history

  4. Reformat

    @cstamas
    cstamas committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    8c10e1b View commit details
    Browse the repository at this point in the history