Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJLINK-9] force NPE on empty sources. #12

Closed
wants to merge 1 commit into from
Closed

[MJLINK-9] force NPE on empty sources. #12

wants to merge 1 commit into from

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Nov 2, 2020

If a separate dist project with packaging=jlink is being used, AND no sources other than a module-info.java are present, this will cause a NPE as indicated in the JIRA issue.

It is intended that his PR will result in a test failure unless the underlying issue is being fixed.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJLINK-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJLINK-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@sormuras sormuras marked this pull request as draft November 11, 2020 19:17
@sormuras
Copy link
Contributor

sormuras commented Nov 11, 2020

Thanks for the PR, Ben. I converted it to a draft -- needs a fix for the NPE to be merged. 🤡

@sormuras
Copy link
Contributor

Superseded by a330205

@sormuras sormuras closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants