JXR-135: IT and some refactoring #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alina, Karl Heinz already picked one of the other PRs for JXR-135. However, the refactoring part is worth adopting. If you can isolate that part, I'm willing to merge those too. |
|
Ah sorry have realized that... |
|
Yes, I have seen that another pull request, nice! |
# Conflicts: # maven-jxr/src/main/java/org/apache/maven/jxr/pacman/JavaFileImpl.java # maven-jxr/src/test/java/org/apache/maven/jxr/pacman/JavaFileImplTest.java
|
Done: pulled last changes from master, eliminated my partial solution from JavaFileImpl keeping IT for JXR-135 (hope it is useful to see the real output for nested inner classes) and refactoring. |
avasiljeva
changed the title
avasiljeva
changed the title
pzygielo
pushed a commit
to pzygielo/maven-jxr
that referenced
this pull request
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided solution will produce proper names for inner classes of one level, what should cover majority of cases.
Covering all possible levels of inner classes is more complicated, but could be built on top of this work.
P.S. I also did minor cleanup while looking through the files (like introducing diamond operator etc).