Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvnd happily fails to load extension and continues on #957

Closed
cstamas opened this issue Apr 20, 2024 · 0 comments · Fixed by #969
Closed

mvnd happily fails to load extension and continues on #957

cstamas opened this issue Apr 20, 2024 · 0 comments · Fixed by #969

Comments

@cstamas
Copy link
Member

cstamas commented Apr 20, 2024

As PR shows:
#953
@cstamas cstamas mentioned this issue Apr 20, 2024
Merged
cstamas added a commit to cstamas/maven-mvnd that referenced this issue Apr 23, 2024
@cstamas
Daemons should not swallow any exception
b7c0e07 
The "happy path" should happen without anything thrown,
unsure why here runtime ex is rethrown, others swallowed.

Fixes apache#957
Fixes apache#968
@cstamas cstamas mentioned this issue Apr 23, 2024
Merged
cstamas added a commit that referenced this issue Apr 23, 2024
@cstamas
Daemons should not swallow any exception (#969)
a6dbd07 
The "happy path" should happen without anything thrown, unsure why here runtime ex is rethrown, others swallowed.

Change: just remove the try/catch and make method throw Exception (diff best seen with whitespace ignored).

Fixes #957
Fixes #966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Daemons should not swallow any exception cstamas/maven-mvnd
1 participant
@cstamas