[MPOM-453] Disable annotation processing by compiler

[slawekjaranowski]

No description provided.

[cstamas]

This can be a problem, as no way to override this later (only in java 20? "full"?) @bmarwell will tell 😄

[slawekjaranowski]

We use sisu-maven-plugin for generating list of components, so should be ok.

[cstamas]

With a grain of salt... I'd rather define compiler.proc=none property and allow that property to be changed, than this. As if project DOES need annotation processing, and is below Java 21 (see https://bugs.openjdk.org/browse/JDK-8309870) then there is no way to override it.

[kwin]

I think it is best practice to only enable annotation processors by their fully qualified class name. This is possible by setting https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#annotationProcessors. This should IMHO take precedence (but I haven’t checked) over proc being none.

[slawekjaranowski]

I need more tests ... like possibility to override

[bmarwell]

We could introduce a property, eg maven.compiler.apt.default or similar. Easy to override per project via .mvn/jvm.options.

I think the way to go is to introduce a new default lifecycle in the compiler plugin in both the compile and test compile Mojos.

This means running a new execution default-process in generate-sources with -proc:only and running a new execution default-test-process in generate-test-sources.

I do this in all of my projects like this.

However, not sure how incremental works with this proposal.

[slawekjaranowski]

• m-compiler-p proc parameter doesn't have a property
• we can use property which can be overridded by empty value, to achieve default behavior, in child project

[bmarwell]

Works for me as of now. Maybe we can look into a project using an annotation processor to make use of the two phases I mentioned and see what we get from it.

[kwin]

LGTM, but would appreciate some comment in the code for the property