Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPOM-294] Remove surefire from Maven site reports #49

Closed
wants to merge 1 commit into from
Closed

[MPOM-294] Remove surefire from Maven site reports #49

wants to merge 1 commit into from

Conversation

slawekjaranowski
Copy link
Member

No description provided.

@michael-o
Copy link
Member

@hboutemy

@hboutemy
Copy link
Member

hboutemy commented Feb 25, 2022

what is the problem with this report?

I find the timing of each test in the report particularly interesting https://maven.apache.org/plugins/maven-deploy-plugin/surefire-report.html

@slawekjaranowski
Copy link
Member Author

The same information we have on CI
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-deploy-plugin/job/master/lastCompletedBuild/testReport/org.apache.maven.plugins.deploy/

The biggest problem for this report is that test phase is triggered during site build ... and can take a long time.

We was start to validate site build on GH, Jenkins and want to improve it.

@hboutemy
Copy link
Member

perhaps CI configuration should not be the same than release-time -Preporting

@michael-o
Copy link
Member

I agreee with @hboutemy I don't see a huge reason to run reporting with CI.

@slawekjaranowski
Copy link
Member Author

The most problematic and what should be tested is javadoc build, reports. But javadoc reports is in reporting profile.

@hboutemy
Copy link
Member

why not just create a separate ci profile?

@slawekjaranowski
Copy link
Member Author

we should run at least one build site (on os and jdk) with reporting profile to be sure that all plugins used in reporting profile still working.

@michael-o michael-o removed their request for review March 24, 2022 22:07
@slachiewicz
Copy link
Member

Knowing that we would have new pom soon - any decisions here?

@Tibor17
Copy link
Contributor

Tibor17 commented Apr 3, 2022

hm, I do not understand his change.
The CI result is used to fail due to Socket time out. The same has happened in the latest surefire result vote. The build was red, we tried to restart the build for 3 days, and finally the build has got green at the end of the Vote.

Instead of removing the surefire report, we should adjust the process and the template should be changed and a new entry should be added along with Site link, SHA512, etc.

If one report is going to be removed, there should be some substitution but mandatory substitution done in prior.

This would improve the process while you prepare the release on your own, but this should not be all. This PR seems to be incomplete.

@slachiewicz
Copy link
Member

@Tibor17
Copy link
Contributor

Tibor17 commented Apr 4, 2022

@slachiewicz
So, this zero report told me that we should ask the developer if the unit tests are really not interesting to write.

@slachiewicz
Copy link
Member

https://maven.apache.org/surefire/surefire-report.html i would say that report is empty becouse running test was disabled while site publish runs

Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants