-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPOM-294] Remove surefire from Maven site reports #49
Conversation
what is the problem with this report? I find the timing of each test in the report particularly interesting https://maven.apache.org/plugins/maven-deploy-plugin/surefire-report.html |
The same information we have on CI The biggest problem for this report is that test phase is triggered during site build ... and can take a long time. We was start to validate site build on GH, Jenkins and want to improve it. |
perhaps CI configuration should not be the same than release-time |
I agreee with @hboutemy I don't see a huge reason to run |
The most problematic and what should be tested is javadoc build, reports. But javadoc reports is in reporting profile. |
why not just create a separate |
we should run at least one build site (on os and jdk) with |
Knowing that we would have new pom soon - any decisions here? |
hm, I do not understand his change. Instead of removing the surefire report, we should adjust the process and the template should be changed and a new entry should be added along with Site link, SHA512, etc. If one report is going to be removed, there should be some substitution but mandatory substitution done in prior. This would improve the process while you prepare the release on your own, but this should not be all. This PR seems to be incomplete. |
@slachiewicz |
https://maven.apache.org/surefire/surefire-report.html i would say that report is empty becouse running test was disabled while site publish runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1
No description provided.