This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add color support auto detection in MessageUtils #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the goal of the xterm check ? |
|
I was "blindly" reproducing the behavior of the jansi library (I don't use windows and I suspected that this was related to cygwin). It seems however that you changed this behavior in the library recently (fusesource/jansi#83) and we should probably also change it here. |
|
Closing this as the issue MNG-6220 was resolved in a different way |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to PR apache/maven#114 and task https://issues.apache.org/jira/browse/MNG-6220