Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce section heading for BOM pattern #188

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

edburns
Copy link
Contributor

@edburns edburns commented Jul 31, 2020

modified: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt

  • TOC: * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}

  • ** {Bill of Materials (BOM) poms}

@edburns
Copy link
Contributor Author

edburns commented Jul 31, 2020

Given how important BOM poms are, I think they deserve a section heading here.

Copy link
Contributor

@mkarg mkarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

…or BOM pattern

modified:   content/apt/guides/introduction/introduction-to-dependency-mechanism.apt

- TOC:    * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}

- ** {Bill of Materials (BOM) poms}

On branch edburns-section-heading-for-bom Apply suggestions from @michael-o.
modified:   content/apt/guides/introduction/introduction-to-dependency-mechanism.apt

- poms > POMs
@edburns edburns force-pushed the edburns-section-heading-for-bom branch from 03dea66 to 477ed1a Compare August 2, 2020 20:33
@edburns edburns requested a review from michael-o August 3, 2020 23:57
@edburns
Copy link
Contributor Author

edburns commented Aug 3, 2020

@michael-o I applied the suggested changes and squashed it to one commit.

@edburns
Copy link
Contributor Author

edburns commented Aug 11, 2020

Hello, this is approved. Can someone please merge it, or let me know what I need to do to have it merged?

Thanks,

Ed

@olamy olamy merged commit fb022a8 into apache:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants