Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNGSITE-430] add dependency POMs #228

Merged
merged 1 commit into from
Feb 12, 2021
Merged

[MNGSITE-430] add dependency POMs #228

merged 1 commit into from
Feb 12, 2021

Conversation

hboutemy
Copy link
Member

No description provided.

@rfscholte
Copy link
Contributor

I suggest to split this up into two:

  • The repository resolution order for a local/reactor pom
  • The repository resolution order for a dependency pom

It must be very clear that transitive dependencies are never effected by repos of their calling pom.

@hboutemy
Copy link
Member Author

hboutemy commented Feb 12, 2021

@rfscholte local POM does not have any resolution: it is locally on disk, from Git
resolution is always for dependencies

transitive dependencies are never effected by repos of their calling pom.

they are affected by repos of their calling pom, that is exactly what resolution order is about

@rfscholte
Copy link
Contributor

The last description is still not clear for me. I think what we're trying to say: repositories within context, i.e the reposities of the pom that defined this pom as a dependency.

@hboutemy
Copy link
Member Author

yes, the last description is the hard one where we need creativity...

"POMs from dependency path to the artifact"?

@rfscholte
Copy link
Contributor

Sometimes images say more than words. Looks like this one should have a picture of a graph to support the logic.

@hboutemy
Copy link
Member Author

yes, we can add such an image in a future step

@asfgit asfgit merged commit 6138193 into master Feb 12, 2021
@hboutemy hboutemy deleted the MNGSITE-430 branch February 12, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants