Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-1688] Add failing test case for failure in BeforeAll method #258

Merged
merged 1 commit into from
Nov 29, 2019
Merged

[SUREFIRE-1688] Add failing test case for failure in BeforeAll method #258

merged 1 commit into from
Nov 29, 2019

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Nov 29, 2019

No description provided.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Nov 29, 2019

@t-8ch
I want to invite you in this PR before I will commit the fix for SUREFIRE-1688.
This pr is different from #257 (SUREFIRE-1727), because here the container's SourceType is Class due to the BeforeAll throws an exception. It is a different business case:

@BeforeAll
static void oneTimeSetUp()
{
    fail( "oneTimeSetUp() failed" );
}

@t-8ch
Copy link

t-8ch commented Nov 29, 2019

@Tibor17 looks fine for me!

@Tibor17 Tibor17 merged commit ae3e0ac into master Nov 29, 2019
@asfgit asfgit deleted the SUREFIRE-1688 branch November 29, 2019 23:37
eolivelli
eolivelli reviewed Nov 30, 2019
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for late reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tibor17 @t-8ch @eolivelli @marcphilipp