Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2038] Upgrade Maven Parent to 35 #491

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member Author

ping for review

Tibor17
Tibor17 previously approved these changes Mar 23, 2022
@Tibor17
Copy link
Contributor

Tibor17 commented Mar 23, 2022

@slawekjaranowski
I approved maybe too early, we need to check the Javadoc by the compiler with <arg>-Xdoclint:all</arg>. Checking it during Site is too late. The contributors can check it by usual build mvn install.

</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<executions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawekjaranowski
I do not know why you have removed this part. The main purpose was <arg>-Xdoclint:all</arg> and we bypass the issue with generated classes HelpMojo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<arg>-Xdoclint:all</arg> still is in configuration line: 392

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HelpMojo now has correct javadocs - we needn't exclude for it

@Tibor17 Tibor17 dismissed their stale review March 23, 2022 20:36

Pending question.

@Tibor17 Tibor17 self-requested a review March 23, 2022 20:37
@slawekjaranowski
Copy link
Member Author

question answered.

@Tibor17
Copy link
Contributor

Tibor17 commented Mar 23, 2022

question answered.

ok, <arg>-Xdoclint:all</arg> is at the line.

No objections from my side.

@slawekjaranowski slawekjaranowski merged commit 4d7ebc7 into master Mar 24, 2022
@slawekjaranowski slawekjaranowski deleted the SUREFIRE-2038 branch March 24, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants