-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-2135] Use native.encoding for parsing ps #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Dec 19, 2022
surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
Outdated
Show resolved
Hide resolved
@andpab thanks 👏 |
andpab
force-pushed
the
SUREFIRE-2135
branch
from
December 19, 2022 08:45
dfa3158
to
b031887
Compare
Amended the commit as suggested by @michael-o New commit message is:
|
issue number should be in square brackets in commit subject, I can change it during merging 😄 |
slawekjaranowski
approved these changes
Dec 19, 2022
- Use the value of the system property native.encoding as charset for parsing the output of the ps command that ForkedBooter issues on Unix-like OSes when checking if the forked process is still alive - Fall back to file.encoding if native.encoding is absent (pre-JDK17) - Fall back further to UTF-8 if file.encoding is not explicitly given - Remove an unnecessary System.out.println in a test that was probably committed by accident This fixes the ConsoleOutputIT on Java 18 and above.
andpab
force-pushed
the
SUREFIRE-2135
branch
from
December 19, 2022 09:52
b031887
to
f68dfb2
Compare
I've amended the commit to add the brackets to the issue reference in the commit message. |
michael-o
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ConsoleOutputIT on Java 18 and above.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
SUREFIRE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean install
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.