Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2143] Fix reporting of skipped parameterized test #612

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

andpab
Copy link
Contributor

@andpab andpab commented Feb 11, 2023

This fixes the regression https://issues.apache.org/jira/browse/SUREFIRE-2143

  • In executionSkipped handle ParameterizedTest which is a non-class test container the same as a regular test
  • In executionSkipped always remove the testIdentifier from the map testStartTime, regardless if it's a class or a test
  • In createReportEntry set methodName and methodText if the testExecutionResult is null, which is the case for skipped tests, otherwise the test name in the XML report is left empty
  • Add ITs also for the related previous issue SUREFIRE-2032 the fix of which caused this regression, to make sure that fix still works

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o requested a review from olamy February 11, 2023 23:27
@slawekjaranowski
Copy link
Member

@andpab please rebase with the latest master - to be sure that all test pass

- In executionSkipped handle ParameterizedTest which is a non-class
  test container the same as a regular test
- In executionSkipped always remove the testIdentifier from the map
  testStartTime, regardless if it's a class or a test
- In createReportEntry set methodName and methodText if the
  testExecutionResult is null, which is the case for skipped tests,
  otherwise the test name in the XML report is left empty
- Add ITs also for the related previous issue SUREFIRE-2032 the fix
  of which caused this regression, to make sure that fix still works
@andpab
Copy link
Contributor Author

andpab commented Feb 17, 2023

All successful except for one macOS build in which the ConsoleOutputIT_largerSoutThanMemory failed - probably an unrelated flake.

@slawekjaranowski slawekjaranowski merged commit b8246dc into apache:master Feb 18, 2023
@andpab andpab deleted the SUREFIRE-2143 branch February 20, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants