Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MVERIFIER-38] Define encoding for FileReader #2

Closed
wants to merge 2 commits into from

Conversation

KroArtem
Copy link
Contributor

After discussions in #1 and in mailing list, I've looked at maven-its project and modello and it's not clear how to replace this plugin there. Thus I've decided to fix this small issue, update dependencies and (probably?) ask for a release.

After that this plugin can be retired. @slachiewicz , WDYT?

If you provide any ideas how to replace usages in repos mentioned above, I can do this as well. (Currently I just don't have enough knowledge about existing tools)

@KroArtem
Copy link
Contributor Author

@slachiewicz, ping

@KroArtem
Copy link
Contributor Author

@slachiewicz, ping again 😃

@slachiewicz
Copy link
Member

Thx for reminder - please look for discussion on maven-dev mailing list

@michael-o
Copy link
Member

Why not use source encoding defined in the POM?

@KroArtem
Copy link
Contributor Author

@slachiewicz , there was no reaction except yours. As I have wrote in this PR, this plugin is used in two places and it is not clear how to replace it there. That's why I decided it's a good idea to fix these issues, release a new version and retire plugin.

@KroArtem
Copy link
Contributor Author

@michael-o , I've missed your comment back then :(

I've also defined encoding in pom.xml but we also discussed FileReader here: #1 (comment)

I still think a new version could be released, then call plugin retired and then create issues to replace this plugin from maven-its project and modello.

@slachiewicz, wdyt?

@KroArtem
Copy link
Contributor Author

I guess this is outdated and should be closed.

@KroArtem KroArtem closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants