Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWRAPPER-33] Adopt Java 8 constructs #80

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[MWRAPPER-33] Adopt Java 8 constructs #80

merged 1 commit into from
Jan 6, 2023

Conversation

timtebeek
Copy link
Contributor

Java 8 brought some possible code improvements over the previous Java 7. These have been applied through:

mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run -DactiveRecipes=org.openrewrite.java.cleanup.CommonStaticAnalysis

With the following results

Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineParser.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.EqualsAvoidsNull
        org.openrewrite.java.cleanup.FinalClass
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLineOption.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineOption.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLine.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/AbstractPropertiesCommandLineConverter.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseLambdaForFunctionalInterface

A few private classes have been made final, but I don't suppose that will be an issue.

All of these changes were automated, so I don't feel particularly attached to them/
Feel free to provide honest feedback if these types of changes are not welcome! :)


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@timtebeek
Copy link
Contributor Author

And a small note perhaps that the recent shellcheck step also runs (and fails) on forks, so some changes there might be in order.

Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, checks will work again after #79 is merged (reviews, please!).

@bmarwell bmarwell mentioned this pull request Jan 5, 2023
1 task
Java 8 brought some possible code improvements over the previous Java 7.
These have been applied through:

mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run
-DactiveRecipes=org.openrewrite.java.cleanup.CommonStaticAnalysis

Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineParser.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.EqualsAvoidsNull
        org.openrewrite.java.cleanup.FinalClass
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLineOption.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineOption.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLine.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/AbstractPropertiesCommandLineConverter.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java by:
    org.openrewrite.java.cleanup.CommonStaticAnalysis
        org.openrewrite.java.cleanup.UseLambdaForFunctionalInterface
@timtebeek
Copy link
Contributor Author

@bmarwell As discussed I've force pushed to this branch now that the parent and formatting has changed in master. Ready for review & merge.

Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarwell bmarwell merged commit 8b48a3f into apache:master Jan 6, 2023
@timtebeek timtebeek deleted the java-8-constructs branch January 7, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants