-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWRAPPER-33] Adopt Java 8 constructs #80
Conversation
And a small note perhaps that the recent shellcheck step also runs (and fails) on forks, so some changes there might be in order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, checks will work again after #79 is merged (reviews, please!).
Java 8 brought some possible code improvements over the previous Java 7. These have been applied through: mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run -DactiveRecipes=org.openrewrite.java.cleanup.CommonStaticAnalysis Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineParser.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.EqualsAvoidsNull org.openrewrite.java.cleanup.FinalClass org.openrewrite.java.cleanup.UseDiamondOperator Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLineOption.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.UseDiamondOperator Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineOption.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.UseDiamondOperator Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLine.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.UseDiamondOperator Changes have been made to maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/AbstractPropertiesCommandLineConverter.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.UseDiamondOperator Changes have been made to maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.UseDiamondOperator Changes have been made to maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java by: org.openrewrite.java.cleanup.CommonStaticAnalysis org.openrewrite.java.cleanup.UseLambdaForFunctionalInterface
@bmarwell As discussed I've force pushed to this branch now that the parent and formatting has changed in master. Ready for review & merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Java 8 brought some possible code improvements over the previous Java 7. These have been applied through:
With the following results
A few private classes have been made final, but I don't suppose that will be an issue.
All of these changes were automated, so I don't feel particularly attached to them/
Feel free to provide honest feedback if these types of changes are not welcome! :)
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MWRAPPER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.