Add org.slf4j.event to exported packages #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maven-core should export org.slf4j.event.* from slf4j-api 1.7.15 or later. For example, this package is where the `Level` class is located.
|
@dconneely Please see MNG-6360. This seems to be overcome already. Can you confirm? |
|
@michael-o Yep - same fix is in #157 👍 |
pzygielo
pushed a commit
to pzygielo/maven
that referenced
this pull request
Jan 4, 2023
…aven version (apache#154) * fix apache#140 by separating no-overwritten test into two basing on maven version * parse maven version by ./mvnw -v * remove redundent code Co-authored-by: yangnuoyu <yangnuoyu@penguin>
pzygielo
pushed a commit
to pzygielo/maven
that referenced
this pull request
Jan 4, 2023
fixes issue introduced in apache#154 trying to fix apache#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maven-core should export org.slf4j.event.* from slf4j-api 1.7.15 or later.
For example, this package is where the
Levelclass is located.Otherwise, issues similar to MNG-5842 and MNG-5845 will arise with plugins that use Slf4j themselves (or more likely plugins that use libraries that use Slf4j).
Discovered while working on in-house Maven plugin that failed with
java.lang.NoClassDefFoundError: org/slf4j/event/Level.