-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6401] - Cannot interpolate property in proxy port of settings.xml #163
Conversation
As far as I understand this PR, you are interpolating the settings before it is fed to |
Can you also provide an IT for that? |
Yes, you are right.
I added the test to maven-integration-testing project. The PR is here. |
Looks interesting. It also looks more efficient. I would like to avoid |
@rfscholte I changed the variable name. Please check. |
on String interpolation vs Object interpolation: what I see in this precise case of proxy port interpolation: it's an int, then it's hard to do Object interpolation on "${param}" value once it has been transfrmed to a String... I know that we have such a case with booleans, where we do not put the effective field type in the descriptor but String for more flexibility: in this boolean case, it was about inheritance, to make the difference between inheriting and overriding with a value. I don't know if we have such cases in Maven core with ints, but the previous pattern hand-writing a typed getter to int should do the job. Now what's the best solution for now:
at this time, I don't have strong opinion: I wanted to write and share the analysis. Now I need to dig into the reasons why we switched from String based interpolation to Object based: this is where we should find the best view on what issue could arise when getting back to former solution |
This is another issue with our interpolation. Can you point me to that handwritten spot?
The core model does not use ints, but only booleans for activation.
I don't see any quality difference between those two, from user POV
This is going to be hard because a lot of our code relies on the int #getPort(). If this PR breaks our approach w/o understanding previous motives, I'd stall it for 3.6.0 or later. |
on handwritten, look at optional field in maven.mdo |
branch 6401-2 pushed, with port and active fields as String and handwritten methods to provide compatibility |
@hboutemy , looks good to me. Did you have a chance to run the new IT on? |
are there any additional steps pending for this fix? |
@agschrei As far as I remember we have discussed this with @rfscholte and there was some logical error either in the expectation or the PR. Can't remember where. |
So we're now close 5 years after this bug was first report. Numerous developers have run into this bug and wasted their time googling this. Was this really necessary???? |
@michael-o
The
So I think the Is there anything else I can do to close this PR? |
…rojects/bom-flattenMode/bom/com.fasterxml.jackson.core-jackson-databind-2.9.10.5
Hi, can we please get some traction on this? It's now the middle of 2023 and yet Maven still has silly issues like this 😢 |
Any updates? |
Superseded by #1194 |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MNG-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.