Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-6776] Inconsistent list of parameters for MojoDescriptor (testcase) #291

Closed
wants to merge 1 commit into from
Closed

[MNG-6776] Inconsistent list of parameters for MojoDescriptor (testcase) #291

wants to merge 1 commit into from

Conversation

slachiewicz
Copy link
Member

@slachiewicz slachiewicz commented Oct 6, 2019 •
edited

No description provided.

@cstamas cstamas mentioned this pull request Oct 12, 2021
Merged
@cstamas
Copy link
Member

cstamas commented Oct 12, 2021

Yup, this is wrong, but: these classes are NOT used/mutated at runtime, but are populated from sources (buildtime) and populated from XML (runtime). Still, this leaves a room for improvement. IMO, you can pick up #584 and this UT and create a PR.

@cstamas
Copy link
Member

cstamas commented Oct 18, 2021

@slachiewicz could you please push the UT to this PR #584 ?

@cstamas
Copy link
Member

cstamas commented Dec 2, 2021

Superseded by #584

@cstamas cstamas closed this Dec 2, 2021
pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
@andpab @slawekjaranowski
apache#291 use scope/optional in profile over default
374abca 
If the scope/optional for a dependency with an entry in dependency
management is explicitly defined in a profile dependency but not in the
dependency management section, then use the scope/optional defined in
the profile dependency rather than falling back to the default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas Awaiting requested review from cstamas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@slachiewicz @cstamas