Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-5577] Use constructor injection and remove the use of @Component #547

Merged
merged 3 commits into from
Oct 2, 2021

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Sep 21, 2021

A few refactoring commits....

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gnodet gnodet changed the title Refactoring Use constructor injection and remove the use of @Component Sep 22, 2021
@gnodet gnodet force-pushed the refactoring branch 2 times, most recently from 3e28e83 to f1cd428 Compare September 23, 2021 16:10
@gnodet gnodet changed the title Use constructor injection and remove the use of @Component [MNG-5577] Use constructor injection and remove the use of @Component Sep 23, 2021
# Conflicts:
#	maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecyclePluginAnalyzer.java
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR overlaps some other things as well (like getting rid of ServiceLocator) I do consider this PR a "good thing". That said, this will 100% conflict with some other PRs (like logging cleanup), so IMO this PR should be merged as soon as possible, then I will update my PRs (logging, Plexus XML, etc)

@cstamas
Copy link
Member

cstamas commented Oct 2, 2021

@gnodet please make sure you ingest all changes of this #440 as then we have two 🪰 (issues) killed with one 👏 (change) (as they are related: ServiceLocator prevents ctor injection, one cannot go without another).

@gnodet
Copy link
Contributor Author

gnodet commented Oct 2, 2021

@gnodet please make sure you ingest all changes of this #440 as then we have two 🪰 (issues) killed with one 👏 (change) (as they are related: ServiceLocator prevents ctor injection, one cannot go without another).

@cstamas The only real difference (beyond spaces) is that I kept the DefaultArtifactDescriptorReader constructor package protected instead of making it public. Otherwise, all the meaningful changes in #440 are included in the commit.

@gnodet gnodet merged commit 35e5a4d into apache:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants