MESOS-6056 add NOOP Container Logger for mesos. #159
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mesos has two Container Loggers in its source files.
One is build into mesos-agent: sandbox Container Logger, it just redirects stderr/stdout to sandbox, causing fill disk usage problem.
The other is LogrotateContainerLogger module lib, it's good, we can make sure stdout/stderr in sandbox be in a constant size.
But there is a common need: don't write stdout/stderr into sandbox, pity, we don't have any flags for turning it off.
This is a come around for this: developing a new module lib for ContainerLogger for doing nothing(redirect stdout/stderr to /dev/null)
yep, that's it. We need a NOOP ContainerLogger,.