Update home.md #243
Closed
Update home.md #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Markup-wise this looked fine to me, but the grid didn't lay out correctly (this new addition appends to the far right on a new row). Maybe someone familiar with bootstrap can figure it out? |
|
The problem is because images have a different height (one have different ratio). We can fix this by scaling them. Just adding max-height: 200px;to book thumbnail should be enough. |
asfgit
pushed a commit
that referenced
this pull request
Oct 27, 2017
There is an issue with books thumbnails. Covers are loaded from external resources and we do not control images sizes and ratios. When one book has different ration than other there might be a situation when there is not enough space (vertically) to place items in a row, so they are located in next row leaving a blank space. Required by: #243 Review: https://reviews.apache.org/r/63379/
|
Thanks @janisz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new book listing - Apache Mesos Cookbook