Remove accent from first name of clems4ever contributor.

[clems4ever]

Review bot fails to apply reviews (with ./support/apply-review.py script) because of the accent in my first name.

[clems4ever]

Hello @tillt , there is an issue with the review bot applying my review: https://reviews.apache.org/r/66621/. I think it is due to the accent in my first name.
So, I created this review to remove the accent. Can you please merge it? Thanks.

[bmahler]

@clems4ever can you post the error? Is this an issue in rbt or our python wrapper script?

[clems4ever]

@bmahler , here is the error from the python script in this review https://reviews.apache.org/r/66621/.

FAIL: Failed to apply the current review.

Failed command: python.exe .\\support\\apply-reviews.py -n -r 66621

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66621

Relevant logs:

apply-review-66621-stderr.log:


Traceback (most recent call last):
  File ".\support\apply-reviews.py", line 447, in <module>
    main()
  File ".\support\apply-reviews.py", line 442, in main
    reviewboard(options)
  File ".\support\apply-reviews.py", line 432, in reviewboard
    apply_review(options)
  File ".\support\apply-reviews.py", line 163, in apply_review
    commit_patch(options)
  File ".\support\apply-reviews.py", line 292, in commit_patch
    shell(cmd, options['dry_run'])
  File ".\support\apply-reviews.py", line 147, in shell
    error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
  File "C:\Program Files\Python27\lib\subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Program Files\Python27\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Program Files\Python27\lib\subprocess.py", line 610, in _execute_child
    args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 23: ordinal not in range(128)

[clems4ever]

Apparently the character \xe9 is é as stated here: https://stackoverflow.com/questions/6327494/what-is-the-following-unicode-string-xe9. So, I really think this is due to my first name.

[bmahler]

We should try to fix apply-reviews.py. Looks related to this discussion?
https://bugs.python.org/issue1759845

[kaysoky]

Here's the associated JIRA: https://issues.apache.org/jira/browse/MESOS-7658

[andyleejordan]

@bmahler Really the only fix is to convert our Python scripts to Python 3. (I tried to get someone at the Hackathon to do this 😉 but failed 😦).

[gkleiman]

I also had to change my name from Gastón to Gaston to stop the Windows reviewbot from failing to apply my patches.

[clems4ever]

Thank you guys for your feedbacks. Since it might take some time to rewrite the script in Python 3 I think it's better to merge this PR so that I can move forward with my review in the review board. What do you think?

[andyleejordan]

@clems4ever Yes, and I'm sorry 😭

[clems4ever]

@andschwa , no problem. Do you have the rights to merge it?

[bbannier]

@clems4ever I don't believe fixing that database is going to make support/apply_reviews.py work. I think you need to reconfigure the name you use to create git commit you put onto reviewboard -- this can be done for just the Mesos repo with git config user name ....

Sorry for the inconvenience :/

[clems4ever]

@bbannier , apparently apply-review.py retrieves data from the profile in the review board. I updated my profile and now the author is correct (I mean without accent).
Thank you for the help.