FaultDomain, conventions for additional hierarchy. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodkone
reviewed
May 31, 2018
| * Complex deployments may have additional levels of hierarchy: for example, | ||
| * multiple racks might be grouped together into "halls" and multiple DCs in | ||
| * the same geographical vicinity might be grouped together. As a convention, | ||
| * the recommended way to represent additional levels of hierarchy is via dot- |
There was a problem hiding this comment.
We don't need to recommend "dot" right? It could be any delimiter that they choose to have? As far as Mesos is concerned, it doesn't matter.
There was a problem hiding this comment.
I realize that Mesos doesn't care. The goal of having a convention was to promote compatibility across frameworks and clusters that can handle additional levels of hierarchy. Consistency suffers w/o convention. This was the justification for adding the same commentary to the design doc, and it's just as relevant (and much easier to find) here.
There was a problem hiding this comment.
@vinodkone did you have any other thoughts on this matter?
|
@jdef would you like to keep this PR open? Doing some grooming today. |
|
Yes, please keep this open.
…On Mon, Aug 27, 2018 at 2:10 PM Greg Mann ***@***.***> wrote:
@jdef <https://github.com/jdef> would you like to keep this PR open?
Doing some grooming today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#294 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLICJznVXoE0OBBsIT0Tuk5bUKwJLks5uVDYDgaJpZM4UUEAK>
.
--
James DeFelice
585.241.9488 (voice)
650.649.6071 (fax)
|
vinodkone
approved these changes
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notes from the "Convention for Additional Hierarchy" of the original design doc: https://docs.google.com/document/d/1gEugdkLRbBsqsiFv3urRPRNrHwUC-i1HwfFfHR_MvC8/edit#heading=h.emfys1xszpir