Marked INTERNET tests in CgroupsIsolatorTest and NamespacesIsolatorTest suite. #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROOT_IPCNamespaceWithIPCModeUnset, ROOT_IPCNamespaceWithIPCIsolatorDisabled, ROOT_ShareIPCNamespace, and ROOT_ShareAgentIPCNamespace try to pull an image from Docker Hub. Marked them as requiring internet access.
ROOT_CGROUPS_NestedContainerSpecificCgroupsMount and ROOT_CGROUPS_CommandTaskSpecificCgroupsMount try to pull an image from Docker Hub to set up a container with rootfs, which is required to test container specific cgroup mounts. Marked as requiring internet access.
|
Thanks! |
andreaspeters
pushed a commit
to m3scluster/clusterd
that referenced
this pull request
Jan 16, 2024
Import from apache#458 ROOT_IPCNamespaceWithIPCModeUnset, ROOT_IPCNamespaceWithIPCIsolatorDisabled, ROOT_ShareIPCNamespace, and ROOT_ShareAgentIPCNamespace try to pull an image from Docker Hub. Marked them as requiring internet access. ROOT_CGROUPS_NestedContainerSpecificCgroupsMount and ROOT_CGROUPS_CommandTaskSpecificCgroupsMount try to pull an image from Docker Hub to set up a container with rootfs, which is required to test container specific cgroup mounts. Marked as requiring internet access. Co-authored-by: Daniel Dadap <daniel@dadap.net> Co-authored-by: Ilya Pronin <ipronin@twitter.com> Reviewed-on: https://gitea:3000/AVENTER/clusterd/pulls/25
DevinLeamy
added a commit
to DevinLeamy/mesos
that referenced
this pull request
Jan 16, 2024
…st suite. (apache#458) * Marked INTERNET tests in NamespacesIsolatorTest suite. ROOT_IPCNamespaceWithIPCModeUnset, ROOT_IPCNamespaceWithIPCIsolatorDisabled, ROOT_ShareIPCNamespace, and ROOT_ShareAgentIPCNamespace try to pull an image from Docker Hub. Marked them as requiring internet access. * Marked INTERNET tests in CgroupsIsolatorTest suite. ROOT_CGROUPS_NestedContainerSpecificCgroupsMount and ROOT_CGROUPS_CommandTaskSpecificCgroupsMount try to pull an image from Docker Hub to set up a container with rootfs, which is required to test container specific cgroup mounts. Marked as requiring internet access. --------- Co-authored-by: Ilya Pronin <ipronin@twitter.com>
DevinLeamy
added a commit
to DevinLeamy/mesos
that referenced
this pull request
Jan 16, 2024
…st suite. (apache#458) * Marked INTERNET tests in NamespacesIsolatorTest suite. ROOT_IPCNamespaceWithIPCModeUnset, ROOT_IPCNamespaceWithIPCIsolatorDisabled, ROOT_ShareIPCNamespace, and ROOT_ShareAgentIPCNamespace try to pull an image from Docker Hub. Marked them as requiring internet access. * Marked INTERNET tests in CgroupsIsolatorTest suite. ROOT_CGROUPS_NestedContainerSpecificCgroupsMount and ROOT_CGROUPS_CommandTaskSpecificCgroupsMount try to pull an image from Docker Hub to set up a container with rootfs, which is required to test container specific cgroup mounts. Marked as requiring internet access. --------- Co-authored-by: Ilya Pronin <ipronin@twitter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROOT_IPCNamespaceWithIPCModeUnset, ROOT_IPCNamespaceWithIPCIsolatorDisabled, ROOT_ShareIPCNamespace, and ROOT_ShareAgentIPCNamespace try to pull an image from Docker Hub. Marked them as requiring internet access.
ROOT_CGROUPS_NestedContainerSpecificCgroupsMount and ROOT_CGROUPS_CommandTaskSpecificCgroupsMount try to pull an image from Docker Hub to set up a container with rootfs, which is required to test container specific cgroup mounts. Marked as requiring internet access.