This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1576: bundle.css RAT failure for metron-interface/metron-alerts #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
Seen during attempt to cut 0.5.0-RC1.
As previously seen in:
https://issues.apache.org/jira/browse/METRON-1373
https://issues.apache.org/jira/browse/METRON-1163
I went and made it a "*" exclusion. There was some concern that if we see this change, we should potentially be rechecking the license for version changes. In that light, is this change too broad?
To make sure it works, you have to do a bit more work than just building it.
untar this file somewhere of your choice.
go to apache-metron-0.5.0/metron-interface/metron-alerts and run
The build should succeed (and fail without this commit).
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.