Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1576: bundle.css RAT failure for metron-interface/metron-alerts #1029

Closed
wants to merge 1 commit into from

Conversation

justinleet
Copy link
Contributor

Contributor Comments

Seen during attempt to cut 0.5.0-RC1.

As previously seen in:
https://issues.apache.org/jira/browse/METRON-1373
https://issues.apache.org/jira/browse/METRON-1163

I went and made it a "*" exclusion. There was some concern that if we see this change, we should potentially be rechecking the license for version changes. In that light, is this change too broad?

To make sure it works, you have to do a bit more work than just building it.

git archive --prefix=apache-metron-0.5.0/ <branch-name> | gzip >  apache-metron-0.5.0.tar.gz

untar this file somewhere of your choice.

tar xvfz apache-metron-0.5.0.tar.gz

go to apache-metron-0.5.0/metron-interface/metron-alerts and run

mvn clean install apache-rat:check -DskipTests

The build should succeed (and fail without this commit).

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@justinleet
Copy link
Contributor Author

kick travis

@justinleet justinleet closed this May 23, 2018
@justinleet justinleet reopened this May 23, 2018
@nickwallen
Copy link
Contributor

+1 Thanks

@asfgit asfgit closed this in 7dad389 May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants