This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1579: Stellar should return the expression that failed in the exception #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,6 +96,19 @@ public String getStreamSubGroup(String enrichmentType, String field) { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think this should be part of stellar itself and not part of enrichment.
There was a problem hiding this comment.
Yeah, I agree. I'll move that.
| @@ -143,7 +143,11 @@ public T parse(final String rule, final VariableResolver variableResolver, final | |||
| try { | |||
| return clazz.cast(expression | |||
| .apply(new StellarCompiler.ExpressionState(context, functionResolver, variableResolver))); | |||
| }finally { | |||
| } | |||
There was a problem hiding this comment.
Maybe we can have stellar exception builders that provide standard, consistent exception building
|
@ottobackwards That makes sense. How do you like it now? |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
There are situations where we are not including the expression in the exception. Also, in stellar enrichments, we should include the relevant variable values in the exception to help with diagnosing issues.
You can try this out in the REPL as well as a stellar enrichment. Use a stellar expression which fails (e.g.
num_var / 0wherenum_varis an integer field).Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.