Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1176 Rest support for setting permissions on files written by HdfsService #749

Closed
wants to merge 3 commits into from

Conversation

ottobackwards
Copy link
Contributor

@ottobackwards ottobackwards commented Sep 12, 2017

This PR adds support to the HdfsController and HdfsService to optional set the permissions on files written to hdfs.

note: this pr is in support of METRON-1136 feature branch, and the installation and management of extensions. Since it is generally applicable, it is being done against master and will be then pulled into
the feature branch. It is blocking the feature branch.

Three new parameters, one each for user, group, and other mode are passed, in the form of symbolic permission strings ('rwx','r-x','r--').

If any of the three are missing, no permission override will be executed.
If any of the three are not valid, and exception will be thrown.

##Testing
[ ] Build, tests should run
[ ] Full Dev, Swagger, use the HdfsController post, and set the permissions, don't set the permissions, set invalid permissions
[ ] Verify files, for example a good place to write to is "/apps/metron/patterns/NAME"
[ ] In the metron ui, testing grok patterns should work

> vagrant ssh
> sudo su -
> hdfs dfs -ls /apps/metron/patterns
  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.

  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [na] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • [na] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

permissions are passes as three strings ( not required ) that represent
symbolic permsions see FsAction.
For example "rw-", "rwx", "r-x"
@merrimanr
Copy link
Contributor

I spun this up in full dev and it worked as expected. Thanks for the contribution. +1

@asfgit asfgit closed this in 95db8b4 Sep 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants