This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1176 Rest support for setting permissions on files written by HdfsService #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the HdfsController and HdfsService to optional set the permissions on files written to hdfs.
Three new parameters, one each for user, group, and other mode are passed, in the form of symbolic permission strings ('rwx','r-x','r--').
If any of the three are missing, no permission override will be executed.
If any of the three are not valid, and exception will be thrown.
##Testing
[ ] Build, tests should run
[ ] Full Dev, Swagger, use the HdfsController post, and set the permissions, don't set the permissions, set invalid permissions
[ ] Verify files, for example a good place to write to is "/apps/metron/patterns/NAME"
[ ] In the metron ui, testing grok patterns should work
Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
[na] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
[na] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html
: