Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1426: SensorIndexingConfigControllerIntegrationTest fails intermittently #906

Closed
wants to merge 2 commits into from

Conversation

mmiklavc
Copy link
Contributor

Contributor Comments

https://issues.apache.org/jira/browse/METRON-1426

Sensor indexing config has a race condition with ZK cache. A similar fix has been made before, but there remained a few test assertions that still potentially had this issue - #795

Testing

Run mvn clean install and verify tests pass. Also, Travis should pass more than once.

Side note: As of submission, there appears to be separate Travis infrastructure issues that are causing timeouts. Will update as new info is available.

Pull Request Checklist

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

@mmiklavc mmiklavc changed the title 1426: SensorIndexingConfigControllerIntegrationTest fails intermittently METRON-1426: SensorIndexingConfigControllerIntegrationTest fails intermittently Jan 24, 2018
@cestella
Copy link
Member

+1

@asfgit asfgit closed this in acb8b92 Jan 25, 2018
iraghumitra pushed a commit to iraghumitra/incubator-metron that referenced this pull request Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants