Merge pull request #35 from thirdwing/master

Make dependencies as submodules
apache · Aug 29, 2015 · 296e942 · 296e942
2 parents 5e9b53b + 0341d2c
commit 296e942
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -34,9 +34,6 @@ doc/latex
 doc/doc
 
 #dmlc
-dmlc-core
-mshadow
-rabit
 config.mk
 
 *.pyc

diff --git a/.gitmodules b/.gitmodules
@@ -0,0 +1,9 @@
+[submodule "mshadow"]
+	path = mshadow
+	url = https://github.com/dmlc/mshadow.git
+[submodule "rabit"]
+	path = rabit
+	url = https://github.com/dmlc/rabit.git
+[submodule "dmlc-core"]
+	path = dmlc-core
+	url = https://github.com/dmlc/dmlc-core.git
diff --git a/README.md b/README.md
@@ -23,5 +23,9 @@ This is a project that combines lessons and ideas we learnt from [cxxnet](https:
 #if DMLC_USE_CXX11
   // c++11 code here
 #endif
+```
+  - Update the dependencies by 
+```
+git submodule foreach --recursive git pull origin master
 ```
 * For heterogenous hardware support (CPU/GPU). Hope the GPU-specific component could be isolated easily. That is too say if we use `USE_CUDA` macro to wrap gpu-related code, the macro should not be everywhere in the project.
diff --git a/dmlc-core b/dmlc-core
diff --git a/mshadow b/mshadow
diff --git a/rabit b/rabit