This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
CMake will not detect a variable as empty string #11584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajiedesign
reviewed
Jul 7, 2018
| @@ -210,7 +210,7 @@ if(USE_CUDA) | |||
| find_package(CUDA REQUIRED) | |||
| add_definitions(-DMSHADOW_USE_CUDA=1) | |||
| if(FIRST_CUDA AND (NOT USE_OLDCMAKECUDA)) | |||
| if(CUDA_TOOLSET STREQUAL "") | |||
| if(NOT CUDA_TOOLSET) | |||
There was a problem hiding this comment.
may be (NOT CUDA_TOOLSET) OR (CUDA_TOOLSET STREQUAL "") is good
There was a problem hiding this comment.
NOT checks for empty string and when the variable is not set, so there is no need for the OR
|
LGTM |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing it with CMake 3.12 it's not detecting that CUDA_TOOLSET is empty