This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-848] Pin dockcross base images in CI #12270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will pin our dockcross base images to known working versions. Pinning these images is necessary as we've had cases where following the 'latest' tag in dockerhub leads us to picking up broken, or incompatible images. Though the dockcross images are generally high-quality we'd like to avoid these issues from blocking our CI in the future.
The disadvantage here is that we will lose visibility in valid failures for things like new cmake versions that potentially break on ARM builds. We feel that these test should be done independently of PR validation, and would be best suited for the nightly test runs.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.