Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[master][ci][feature] Prospector tool to analyze Python code #20684

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Oct 20, 2021

Description

There is used Prospector ' tool to perform additional formatting and semantic checking of code. Prospector is a tool to analyse Python code and output information about errors, potential problems, convention violations and complexity. (Related to: #20406, #20356)

Since Prospector needs to be installed with an appropriate configuration, the file with the requirements has to be run:

pip install prospector

To run a Prospector , open your terminal and type:

python3 -m prospector --profile prospector.yaml

Future improvements:

  • Check only changed files.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, sanity, centos-cpu, windows-gpu, unix-cpu, clang, edge, windows-cpu, miscellaneous, centos-gpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2021
@mozga-intel mozga-intel force-pushed the mozga-intel/prospector_python_checker branch from 5d11c69 to 6e75b7a Compare October 22, 2021 06:53
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2021
@mozga-intel mozga-intel force-pushed the mozga-intel/prospector_python_checker branch from cca764a to 6e75b7a Compare October 22, 2021 19:02
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Oct 22, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 25, 2021
@@ -1,99 +0,0 @@
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify if this file should be deleted. What about md files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @anko-intel; thanks! I ruled it out, but It looks like that it's still needed on many counts.

@mozga-intel mozga-intel force-pushed the mozga-intel/prospector_python_checker branch from ca0dd29 to 46000fb Compare October 27, 2021 11:49
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 27, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 28, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 28, 2021
@szha szha merged commit 79e1753 into apache:master Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants