Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[io]let all io randomness be related to time(0) #3001

Closed
wants to merge 1 commit into from
Closed

[io]let all io randomness be related to time(0) #3001

wants to merge 1 commit into from

Conversation

tornadomeet
Copy link
Contributor

related to #2968
let all randomness with seed be related to time(0)

if not related to time(0), then every time when rerun program the randomness is the same. this will fix it, but i'm not sure whether it will influence other part.
@tqchen @piiswrong

let all randomness with seed be related to time(0)
@tornadomeet tornadomeet changed the title [io]src/io/iter_image_recordio.cc [io]let all io randomness be related to time(0) Aug 11, 2016
@winstywang
Copy link
Contributor

We need to discuss the behavior of this change. This design is deliberated at the beginning since we could reproduce the results exactly if we run the same codes. But it certainly will repeat the randomness if the program terminates and rerun.

What are your opinions?
@tqchen @piiswrong @antinucleon

@tqchen
Copy link
Member

tqchen commented Aug 11, 2016

I think we should keep this behavior for now, reproduciblity is quite important, we can, however, enable a global seed that can be seeded through some functions and allow user to pass in the time seed

@tqchen tqchen closed this Aug 11, 2016
@tornadomeet
Copy link
Contributor Author

tornadomeet commented Aug 12, 2016

@tqchen @winstywang user can pass seed by itself indeed, but currently the seed option is only used in shuffle, i.e. rnd_, not used for any others image augmentation, i.e. prnds_.so should we bring in another seed in ImageRecParserParam(this may puzzled the user)? or change the code to make ImageRecParserParam and ImageRecordParam share the same seed?

@winstywang
Copy link
Contributor

@tornadomeet Yes, we need that modification

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants