Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "Temporarily disable test with failing http connection (#9333)" #9379

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Jan 11, 2018

This reverts commit 8ad77f3.

Description

For the time being the server seems to be stable again, so I'm opening this PR to optionally allow commiters to re-enable the tests.

I feel this test should be refactored such that future web server outages don't break the build. The test seems to be mostly setting up declarative code. During a quick review I noticed that there's for example no asserts in the majority of these tests. It would be great if someone could verify that these tests are actually testing their respective intended units of work.

If merged this addresses issue: #9332

@cjolivier01 cjolivier01 merged commit 51ea815 into apache:master Jan 12, 2018
CodingCat pushed a commit to CodingCat/mxnet that referenced this pull request Jan 16, 2018
yuxiangw pushed a commit to yuxiangw/incubator-mxnet that referenced this pull request Jan 25, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants