-
Notifications
You must be signed in to change notification settings - Fork 6.8k
"Matrix Factorization" R test failing due to unavailable HTTP server. #9332
Comments
Looks like this dataset has been posted again. It's a 4.9 MB file. The licensing and redistribution details are included in an attached README. The relevant sections to me are:
To me it remains somewhat vague given these terms if we can cache this data in our CI setup somewhere. If no-one objects I'd recommend contacting the authors. |
Another option given the simplicity of the dataset (movie rankings) would be to generate a dataset locally that adheres to the same formatting. |
We're actually never calling predict and never calling expect_equal in this test, unlike for example the 'MNIST' test. This further convinces me that we don't need to be using real data here, and can probably use generated data. I also get the impression we can narrow the scope of this test, such that it focuses on a single 'unit under test'. |
Description
All PRs are currently failing due to a R test that's attempting to download a dataset from an unavailable web server.
The unavailable file is http://files.grouplens.org/datasets/movielens/ml-100k.zip.
The affected test: "Matrix Factorization"
Environment info (Required)
CI
Notes
Disabled in PR #9333
@szha Would you be able to tag this one as a flaky test?
The text was updated successfully, but these errors were encountered: