Ensure new .a file needed before deleting old
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newt prints a message when it compiles, copies, archives, or links. The first letter of this message is capitalized in all cases except the "copying" message. This commit changes it to "Copying..."
When creating a .a file for a package, newt first deletes the existing .a file from the previous build. There is one case where this causes problems: the package's source directory contains a .a file with the same name that newt plans to use. In this case, newt confuses the input .a file as an artifact from a prior build and deletes it. The fix is to delay the deletion of the old .a file until after ensuring that a new .a file will be built. Newt determines if it will be building a new .a file by checking if any .o files were produced for the package. Thus, a package consisting only of .a files does not generate a new .a file.
utzig
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a
.afile for a package, newt first deletes the existing.afile from the previous build. There is one case where this causes problems: the package's source directory contains a.afile with the same name that newt plans to use. In this case, newt confuses the input.afile as an artifact from a prior build and deletes it.The fix is to delay the deletion of the old
.afile until after ensuring that a new.afile will be built. Newt determines if it will be building a new.afile by checking if any.ofiles were produced for the package. Thus, a package consisting only of.afiles does not generatea new
.afile.