Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure new .a file needed before deleting old #168

Merged
merged 2 commits into from
May 22, 2018
Merged

Ensure new .a file needed before deleting old #168

merged 2 commits into from
May 22, 2018

Commits on May 22, 2018

  1. Capitalize first letter in "copying" message. 

    Newt prints a message when it compiles, copies, archives, or links.  The
first letter of this message is capitalized in all cases except the
"copying" message.

This commit changes it to "Copying..."
    @ccollins476ad
    ccollins476ad committed May 22, 2018
    Configuration menu
    Copy the full SHA
    c35dc73 View commit details
    Browse the repository at this point in the history

  2. Ensure new .a file needed before deleting old 

    When creating a .a file for a package, newt first deletes the existing
.a file from the previous build.  There is one case where this causes
problems: the package's source directory contains a .a file with the
same name that newt plans to use.  In this case, newt confuses the
input .a file as an artifact from a prior build and deletes it.

The fix is to delay the deletion of the old .a file until after ensuring
that a new .a file will be built.  Newt determines if it will be
building a new .a file by checking if any .o files were produced for the
package.  Thus, a package consisting only of .a files does not generate
a new .a file.
    @ccollins476ad
    ccollins476ad committed May 22, 2018
    Configuration menu
    Copy the full SHA
    8695d59 View commit details
    Browse the repository at this point in the history