Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the min. changes required to support the GF variant. #1492

Conversation

ioannis-karachalios
Copy link

No description provided.

@ioannis-karachalios ioannis-karachalios force-pushed the smartbond_da1469x_GF_silicon_support branch from 9c3e97f to 45c32b2 Compare May 4, 2023 15:30
Copy link
Contributor

@andrzej-kaczmarek andrzej-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add "nimble/phy/cmac:" prefix to commit title

@@ -1178,6 +1186,8 @@ ble_phy_init(void)
g_ble_phy_data.phy_whitening = 1;
#endif

set_reg32_bits(0x40000904, 0x0004, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to ble_rf_init

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code line deals with suppressing a meta-stability issue from raising an error condition towards the controller, mainly observed in GF variant. Preferably, this should be executed as early as possible and is not related to the RF part. Is there any specific reason why ble_rf_init() is recommended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. That is the place I was looking for...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ioannis-karachalios ioannis-karachalios force-pushed the smartbond_da1469x_GF_silicon_support branch from 45c32b2 to ad564a1 Compare May 8, 2023 11:46
@@ -114,6 +122,20 @@ set_reg16_mask(uint32_t addr, uint16_t mask, uint16_t val)
*reg = (*reg & (~mask)) | (val & mask);
}

static inline int read_chip_variant(void)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static inline int
read_chip_variant(void)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@andrzej-kaczmarek
Copy link
Contributor

please rebase to master instead or merging master branch

Copy link
Contributor

@andrzej-kaczmarek andrzej-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failures are not related to this PR, will fix separately

@andrzej-kaczmarek andrzej-kaczmarek merged commit c514f5b into apache:master May 8, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants