New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the min. changes required to support the GF variant. #1492
Add the min. changes required to support the GF variant. #1492
Conversation
9c3e97f
to
45c32b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add "nimble/phy/cmac:" prefix to commit title
@@ -1178,6 +1186,8 @@ ble_phy_init(void) | |||
g_ble_phy_data.phy_whitening = 1; | |||
#endif | |||
|
|||
set_reg32_bits(0x40000904, 0x0004, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to ble_rf_init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code line deals with suppressing a meta-stability issue from raising an error condition towards the controller, mainly observed in GF variant. Preferably, this should be executed as early as possible and is not related to the RF part. Is there any specific reason why ble_rf_init() is recommended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in such case you can put it in SystemInit
instead: https://github.com/apache/mynewt-core/blob/master/hw/mcu/dialog/cmac/src/system_cmac.c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. That is the place I was looking for...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
45c32b2
to
ad564a1
Compare
@@ -114,6 +122,20 @@ set_reg16_mask(uint32_t addr, uint16_t mask, uint16_t val) | |||
*reg = (*reg & (~mask)) | (val & mask); | |||
} | |||
|
|||
static inline int read_chip_variant(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static inline int
read_chip_variant(void)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
please rebase to |
abf9c9a
to
2a8ab41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build failures are not related to this PR, will fix separately
No description provided.