nimble/phy: Allow to selectively enable workaround for nRF52840 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are known anomalies in nRF52840 engineering and final revisions which, according to Nordic DevZone, should be only applied to chip version affected. For this reason We need to allow workarounds for apache#164 and apache#191 to be enabled selectively. Default configuration applies to nRF52840 Rev 1 (final silicon) and Engineering B and C. When building for nRF52840 Engineering A (found on early versions on nRF52840 PDK) configuration should be changed.
sjanc
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are known anomalies in nRF52840 engineering and final revisions
which, according to Nordic DevZone, should be only applied to chip
version affected. For this reason We need to allow workarounds for #164
and #191 to be enabled selectively.
Default configuration applies to nRF52840 Rev 1 (final silicon) and
Engineering B and C.
When building for nRF52840 Engineering A (found on early versions on
nRF52840 PDK) configuration should be changed.