Remove notification for update process timeout. #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymanluk
reviewed
Mar 25, 2020
zacwbond
force-pushed
the
hotfix/timeout
branch
from
2295962
to
1492d6f
Compare
rymanluk
requested changes
Mar 26, 2020
There was a problem hiding this comment.
Thanks for updating commit message.
Could you please change it to following (also please try keep max 80 chars per line):
"The connection parameter update process has a hard-coded 40-second timeout,
but in reality, the time it takes to complete a connection parameter might take longer, as it
depends on the connection interval and when controller deciders to do it.
This patch changes meaning of this 40 sec timer to be only a guard so the application
does not perform too many connection update parameter requests.
Now when timeout fires, application will not be notified about that and link will not be dropped."
As you can see also Travis complains on this patch. Please check details.
You can reproduce the problem by running unit test on your PC
"newt test @apache-mynewt-nimble/nimble/host/test"
To solve it please remove ble_gap_test_util_update_no_l2cap_tmo function as we don't need it anymore.
zacwbond
force-pushed
the
hotfix/timeout
branch
from
1492d6f
to
0fe52eb
Compare
The connection parameter update process has a hard-coded 40-second timeout, but in reality, the time it takes to complete a connection parameter might take longer, as it depends on the connection interval and when controller deciders to do it. This patch changes meaning of this 40 sec timer to be only a guard so the application does not perform too many connection update parameter requests. Now when timeout fires, application will not be notified about that and link will not be dropped.
zacwbond
force-pushed
the
hotfix/timeout
branch
from
0fe52eb
to
3d7c9e6
Compare
Style check summaryNo suggestions at this time! |
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
May 22, 2020
Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes #4413
mahavirj
pushed a commit
to mahavirj/esp-afr-sdk
that referenced
this pull request
Jun 1, 2020
… (backport v3.3) Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes espressif/esp-idf#4413
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jun 15, 2020
… (backport v4.0) Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes #4413
projectgus
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jul 22, 2020
… (backport v4.1) Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes #4413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This addresses issue #780, just like PR #781, which was closed due to some repo juggling on my end.)
From the original
Based on @rymanluk's comments to that PR, I have reduced the change to keeping the 40s timeout, but simply not posting an event should a timeout occur.