nimble/gap: Fix storing CCC for bonded devices. #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h2zero could you please have a look on that? |
This PR make sure that ble_gatts_bonding_established is called only when bonded. Note: renamed not used "persist_keys" to "bonded" and make use of it Bug can be easly reproduced when BLE_SM_BONDING: 0 BLE_HS_DEBUG: 1 Program received signal SIGTRAP, Trace/breakpoint trap. ble_gatts_bonding_established (conn_handle=conn_handle@entry=1) at repos/apache-mynewt-nimble/nimble/host/src/ble_gatts.c:1681 1681 BLE_HS_DBG_ASSERT(conn->bhc_sec_state.bonded); (gdb)
Style check summaryNo suggestions at this time! |
|
@rymanluk Just put it through testing and works as it should 👍. A quick note for @prasad-alatkar for this PR to work on the esp32 we also need #730 |
andrzej-kaczmarek
approved these changes
Apr 22, 2020
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
May 22, 2020
Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes #4413
mahavirj
pushed a commit
to mahavirj/esp-afr-sdk
that referenced
this pull request
Jun 1, 2020
… (backport v3.3) Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes espressif/esp-idf#4413
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jun 15, 2020
… (backport v4.0) Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes #4413
projectgus
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jul 22, 2020
… (backport v4.1) Change list: - Reduces the size of the compiled binary, PR: espressif/esp-nimble#6 - Null pointer check, PR: apache/mynewt-nimble#701 - Pairing procedure abort on unexpected req: apache/mynewt-nimble#710 - Fix conn flags after pairing: apache/mynewt-nimble#730 - Remove notification for update process timeout (Vol 6, Part B, section 5.2 ): apache/mynewt-nimble#782 - CCCD fix : apache/mynewt-nimble#790 and apache/mynewt-nimble#804 - Host based Privacy (RPA) fix: espressif/esp-nimble#7 Closes espressif/esp-nimble#10 Closes #4413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make sure that ble_gatts_bonding_established is called only when
bonded.
Note: renamed not used "persist_keys" to "bonded" and make use of it
Bug can be easly reproduced when
BLE_SM_BONDING: 0
BLE_HS_DEBUG: 1
Program received signal SIGTRAP, Trace/breakpoint trap.
ble_gatts_bonding_established (conn_handle=conn_handle@entry=1) at repos/apache-mynewt-nimble/nimble/host/src/ble_gatts.c:1681
1681 BLE_HS_DBG_ASSERT(conn->bhc_sec_state.bonded);
(gdb)