Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSNetBeans build fails on java.mx.project missing tag in build.xml #5196

Closed
MartinBalin opened this issue Jan 4, 2023 · 4 comments · Fixed by #5199
Closed

VSNetBeans build fails on java.mx.project missing tag in build.xml #5196

MartinBalin opened this issue Jan 4, 2023 · 4 comments · Fixed by #5199
Assignees
Labels
GraalVM [ci] enable GraalVM tests kind:bug Bug report or fix VSCode Extension [ci] enable VSCode Extension tests

Comments

@MartinBalin
Copy link
Contributor

Apache NetBeans version

Apache NetBeans 16

What happened

VSNetBeans builder failed at https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/1389/consoleText
at bottom there is following error:

-checkout-graalvm:
     [exec] Cloning into 'graal'...
     [exec] warning: Could not find remote branch vm-20.3.0 to clone.
     [exec] fatal: Remote branch vm-20.3.0 not found in upstream origin

BUILD FAILED
/home/jenkins/workspace/Netbeans/netbeans-vscode/java/java.mx.project/build.xml:30: exec returned: 128

Checking https://github.com/oracle/graal git repo there is no vm-20.3.0 tag nor branch. Similarly there is also a reference to mx branch 5.279.0 at the same build.xml.
The failure happened with build #1389, VSIX itself is built.

How to reproduce

See the build on jenkins https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/1389/

Did this work correctly in an earlier version?

No / Don't know

Operating System

ubuntu jenkins builder

JDK

JDK11

Apache NetBeans packaging

Apache VSNetBeans for VSCode

Anything else

No response

Are you willing to submit a pull request?

Yes

Code of Conduct

Yes

@MartinBalin MartinBalin added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Jan 4, 2023
@MartinBalin MartinBalin added VSCode Extension [ci] enable VSCode Extension tests GraalVM [ci] enable GraalVM tests and removed needs:triage Requires attention from one of the committers labels Jan 4, 2023
@sdedic
Copy link
Member

sdedic commented Jan 4, 2023

I have an older copy of graalvm git repo, it seems that someone pruned the tags in the public repository (?). For the reference, the commit ids are

  • vm-20.3.0 => c5ff5a5a091bfd974640aaf6fbe51c81bd080438
  • vscode-20.3.0 => 26431bf1b00dc23da5fbd8b89f02060f8cfd4811
  • mx 5.279.0 => dcfad27487a5d13d406febc92976cf3c026e50dd

note that tag 5.279.0 still exists in graal/mx repository.

sdedic added a commit to sdedic/incubator-netbeans that referenced this issue Jan 4, 2023
@sdedic sdedic linked a pull request Jan 4, 2023 that will close this issue
sdedic added a commit to sdedic/incubator-netbeans that referenced this issue Jan 5, 2023
mbien added a commit that referenced this issue Jan 5, 2023
Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
@jtulach
Copy link
Contributor

jtulach commented Jan 7, 2023

someone pruned the tags in the public repository (?)

Unbelievable! OracleLabs guys should provide a justification why they believe removing tagged releases is a good practice. @MartinBalin why did that happen?

Thanks for the #5199 fix - that shall be enough until some clever mind decides to rewrite whole history or the repository...

@jtulach
Copy link
Contributor

jtulach commented Jan 11, 2023

According to slack discussion the missing tag is back:

this is a bug and is going to be fixed....
.... The bug is fixed and deployed, the missing tags are now avail ...
The tags are back online and we've made sure this cannot happen again. Sorry for the inconvenience!

Thank you. The (development) world seems to be a consistent place again.

@mbien
Copy link
Member

mbien commented Jan 11, 2023

if its back online as the quote says and also there to stay we should probably revert #5199 again - or at least then when the next time the version is bumped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GraalVM [ci] enable GraalVM tests kind:bug Bug report or fix VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants