Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5250: Update java.mx.project to work with GraalVM 22.3.0 release. #5285

Merged
merged 5 commits into from
Jan 13, 2023
Merged

Issue #5250: Update java.mx.project to work with GraalVM 22.3.0 release. #5285

merged 5 commits into from
Jan 13, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Jan 12, 2023

GraalVM used by java.mx.project updated to 22.3.0 release.

@dbalek dbalek added VSCode Extension [ci] enable VSCode Extension tests MX [ci] enable "build tools" tests GraalVM [ci] enable GraalVM tests labels Jan 12, 2023
@dbalek dbalek added this to the NB17 milestone Jan 12, 2023
@dbalek dbalek linked an issue Jan 12, 2023 that may be closed by this pull request
Update java.mx.project to work with GraalVM 22.3.0 release #5250
Closed
@mbien
Copy link
Member

mbien commented Jan 12, 2023

wouldn't it be better to revert #5199 again to check out tags like before?

@jtulach mentions here that tags will stay in the graal repo now.

MartinBalin
MartinBalin approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@MartinBalin MartinBalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you

jtulach
jtulach approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@jtulach jtulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a smooth upgrade.

mbien
mbien reviewed Jan 12, 2023
View reviewed changes
...a.mx.project/test/unit/src/org/netbeans/modules/java/mx/project/SuiteActionProviderTest.java
progress.finished.await(45, TimeUnit.SECONDS);
progress.finished.await(600, TimeUnit.SECONDS);
Copy link
Member

@mbien mbien Jan 12, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried to reproduce the issues with this test locally a few times already. But it always passes. This test is also super fast if i remember correctly. It finishes in 700ms or so (the setup takes a bit longer).

So I don't think this could be timeout related - but who knows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also as note: the tests are wrapped in a retry script which retries twice on failure. So long timeout could lead to really long test times on failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time it failed with the AssertionError thrown from SuiteActionProviderTest.java#L95

Copy link
Member

@mbien mbien Jan 12, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. that one fails very often. Yesterday A few days ago I looked at the last 18 merges to master and wrote down all failures to wrap tests in retry scripts #5254. This test was on top.

mbien
mbien approved these changes Jan 12, 2023
View reviewed changes
.github/workflows/main.yml
java: [ '8' ]
java: [ '11' ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@dbalek dbalek merged commit 312e6a4 into apache:master Jan 13, 2023
@dbalek dbalek deleted the dbalek/5250 branch January 13, 2023 07:25
sdedic pushed a commit that referenced this pull request Jan 13, 2023
@dbalek @sdedic
Issue #5250: Update java.mx.project to work with GraalVM 22.3.0 relea…
70ab4eb 
…se. (#5285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@jtulach jtulach jtulach approved these changes

@MartinBalin MartinBalin MartinBalin approved these changes

@sdedic sdedic Awaiting requested review from sdedic

Assignees
No one assigned
Labels
GraalVM [ci] enable GraalVM tests MX [ci] enable "build tools" tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

Update java.mx.project to work with GraalVM 22.3.0 release
4 participants
@dbalek @mbien @jtulach @MartinBalin