Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-3202] Fix issue in Text Block #1570

Merged
merged 4 commits into from
Dec 2, 2019
Merged

[NETBEANS-3202] Fix issue in Text Block #1570

merged 4 commits into from
Dec 2, 2019

Conversation

Akshay-Gupta-19
Copy link
Contributor

@Akshay-Gupta-19 Akshay-Gupta-19 commented Oct 14, 2019 •
edited
Loading

[NETBEANS-3202] Fix issue in Text Block

@neilcsmith-net
Copy link
Member

If intended for 11.2(?), please add milestone and add me as reviewer when ready. That added if statement probably needs formatting and braces too?

@junichi11
Copy link
Member

@Akshay-Gupta-Oracle Please use [NETBEANS-XXXX](e.g. [NETBEANS-3202]) instead of [Netbeans:3202] because the link of this PR is added to the JIRA.

@junichi11 junichi11 changed the title [Netbeans:3202] Fix issue in Text Block [NETBEANS-3202] Fix issue in Text Block Oct 14, 2019
@neilcsmith-net neilcsmith-net added this to the 11.3 milestone Oct 17, 2019
geertjanw
geertjanw approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@geertjanw geertjanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@arusinha arusinha merged commit 4a21981 into apache:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdedic sdedic sdedic left review comments

@geertjanw geertjanw geertjanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Akshay-Gupta-19 @neilcsmith-net @junichi11 @geertjanw @sdedic @arusinha