[NETBEANS-377] Add PSR-4 hints #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should leave a comment for unsupported cases somewhere. Add a test for the following case? // file: Vendor/App/ClassName.php
namespace Vendor\App;
class classname {
} |
junichi11
reviewed
Jan 5, 2021
php/php.editor/src/org/netbeans/modules/php/editor/verification/PSR4Hint.java
Outdated
Show resolved
Hide resolved
KacerCZ
force-pushed
the
netbeans-377-psr4-hints
branch
from
e6bef1a
to
4fe6751
Compare
|
I added tests where casing is different. Also added note about case-sensitivity to hint descriptions:
|
tmysik
reviewed
Jan 7, 2021
php/php.editor/src/org/netbeans/modules/php/editor/verification/Bundle.properties
Show resolved
Hide resolved
php/php.editor/src/org/netbeans/modules/php/editor/verification/PSR4Hint.java
Show resolved
Hide resolved
https://issues.apache.org/jira/browse/NETBEANS-377 - Added hints for [PSR-4 Autoloader](https://www.php-fig.org/psr/psr-4/) standard. - Checks that class/interface/trait declaration matches file name. - Checks that namespace matches directory structure. - Highlights only non-matching part of namespace.
KacerCZ
force-pushed
the
netbeans-377-psr4-hints
branch
from
4fe6751
to
7efb4f8
Compare
tmysik
approved these changes
Jan 7, 2021
junichi11
approved these changes
Jan 7, 2021
|
Will re-run jobs. |
|
@junichi11 @tmysik Thanks for review. |
|
Does this feature support psr-4 declaration from composer.json? |
|
@ahajzik-crido No, mapping from composer.json is separate task - https://issues.apache.org/jira/browse/NETBEANS-5341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/NETBEANS-377