Return a copy instead of cached array #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
approved these changes
Sep 13, 2021
| @@ -241,7 +241,7 @@ public ClassPathImplementation getClassPathImpl(ClassPath cp) { | |||
| long current; | |||
| synchronized (this) { | |||
| if (rootsCache != null) { | |||
| return this.rootsCache; | |||
| return Arrays.copyOf(rootsCache, rootsCache.length); | |||
There was a problem hiding this comment.
I'd use this.rootsCache.clone().
There was a problem hiding this comment.
Good point; recommitted as 3fc65de. Thanks.
sdedic
force-pushed
the
bugfix/classpath-copy
branch
from
4111a68
to
3fc65de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some implementation I've mindlessly modified the result of
ClassPath.getRoots()call ... and then spent more than 5 hours by hunting down the bug since it wasn't originally obvious, but "sometimes" the parser stopped to resolving symbols against the classpath. "sometimes" = when the added (debugging) code run and modified the ClassPath caches for all IDE.I think making the code fool-proof is worth the array-copy overhead...