Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must reach ELEMENTS_RESOLVED before working with java els #3184

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Must reach ELEMENTS_RESOLVED before working with java els #3184

merged 2 commits into from
Oct 6, 2021

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Sep 22, 2021

Even after recent delivery merge, I've found some more places where I should call .toPhase().

@sdedic sdedic requested a review from dbalek September 22, 2021 15:06
@sdedic sdedic self-assigned this Sep 30, 2021
@sdedic sdedic added kind:bug Bug report or fix Groovy labels Sep 30, 2021
JaroslavTulach
JaroslavTulach approved these changes Oct 5, 2021
View reviewed changes
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve anything you wish.

@ebarboni ebarboni added this to the 12.6 milestone Oct 5, 2021
@sdedic sdedic merged commit 9a25ef5 into apache:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbalek dbalek dbalek approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

Assignees

@sdedic sdedic

Labels
Groovy kind:bug Bug report or fix
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.
4 participants
@sdedic @dbalek @JaroslavTulach @ebarboni