Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-5599] PHP 8.1 Support #3463

Merged
merged 17 commits into from Jan 16, 2022
Merged

[NETBEANS-5599] PHP 8.1 Support #3463

merged 17 commits into from Jan 16, 2022

Conversation

junichi11
Copy link
Member

junichi11 and others added 16 commits November 22, 2021 22:52
https://issues.apache.org/jira/browse/NETBEANS-5599

- Fix the grammar file
- Add `FinalModifierHintError` and `PHP81UnhandledError`
- Add unit tests
[NETBEANS-5599] PHP 8.1 Support: Final class constants part
- Use `HintErrorRule` instead of `UnhandledError`
- Add unit tests
https://issues.apache.org/jira/browse/NETBEANS-5599

RFC: https://wiki.php.net/rfc/noreturn_type

- Add `hasNeverType()` to `PhpVersion`
- Fix the lexer
- Mark as an error if something is returned when the return type is `never`
- Mark as an error if `never` is used at incorrect places (e.g. private never $propertyType)
- Add unit tests for the lexer and hints
[NETBEANS-5599] PHP 8.1 Support: Never type
https://issues.apache.org/jira/browse/NETBEANS-5599

RFC:https://wiki.php.net/rfc/readonly_properties_v2

The lexer, the parser, and hints

- Fix the lexer and the parser
- Add `readonly` as a new modifier
- Fix `ModifiersCheckHintError`
- Add unit tests for the lexer, the parser, and hints
https://issues.apache.org/jira/browse/NETBEANS-5599

RFC:https://wiki.php.net/rfc/readonly_properties_v2

Code Completion and Formatter

- Fix the code completion feature
- Add/Fix unit tests for the code completion and the formatter
[NETBEANS-5599] PHP 8.1 Support: Readonly Properties 2.0
[NETBEANS-5599] PHP 8.1 Support: New in initializers
https://issues.apache.org/jira/browse/NETBEANS-5599

RFC: https://wiki.php.net/rfc/pure-intersection-types

Parser&Lexer:
- Fix the `ASTPHP5Parser.cup` and `ASTPHP5Scanner.flex`
- Fix the `PHP81UnhandledError`
- Add the `IntersectionType` as a new AST node
- Add and fix the unit tests for the parser
- Fix the Navigator
https://issues.apache.org/jira/browse/NETBEANS-5599

RFC: https://wiki.php.net/rfc/pure-intersection-types

GotoDeclaration, MarkOccurrences, Formatter:

- Fix GotoDeclaration, MarkOccurrences, and Formatter features
- Add unit tests
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jan 15, 2022
@junichi11 junichi11 added this to the NB13 milestone Jan 15, 2022
@junichi11 junichi11 requested a review from tmysik January 15, 2022 23:41
@junichi11
Copy link
Member Author

Will merge this after #3461 is merged.

[NETBEANS-5599] PHP 8.1 Support: Pure intersection types
@tmysik
Copy link
Member

tmysik commented Jan 16, 2022

@junichi11 Approved, of course. Please, let me know if you are going to merge it or whether I should do it. Thank you!

@junichi11
Copy link
Member Author

@tmysik Please merge it. Thank you!

@tmysik tmysik merged commit 415e455 into master Jan 16, 2022
@junichi11 junichi11 deleted the php81-support branch February 18, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants